Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always copy to "/" (root). Fixes #1954 #1956

Merged
merged 2 commits into from Oct 8, 2019
Merged

Always copy to "/" (root). Fixes #1954 #1956

merged 2 commits into from Oct 8, 2019

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Oct 6, 2019

As seen in #1814, we introduced a regression in 1.12.1.

This PR makes the copy API always target the root and then uses the full path in the archive we send to the daemon.

@bsideup bsideup added this to the next milestone Oct 6, 2019
@bsideup bsideup mentioned this pull request Oct 6, 2019
Merged
@rnorth
Copy link
Member

rnorth commented Oct 8, 2019

Good catch - thank you. I'll hit the merge button.

@rnorth rnorth merged commit b08308f into master Oct 8, 2019
@rnorth rnorth deleted the always_copy_to_root branch October 8, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.12.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth