Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SELF typing for OracleContainer #1425

Merged
merged 3 commits into from Apr 27, 2019
Merged

Support SELF typing for OracleContainer #1425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75fc1ac
PR #1292 Added waitUntilContainerStarted and adjusted OracleContainer…
Apr 25, 2019
a6b9580
PR #1292 Do not override waitUntilContainerStarted method. Changed cl…
Apr 26, 2019
e114dd3
Merge branch 'master' into pr/1292
rnorth Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@
/**
* @author gusohal
*/
public class OracleContainer extends JdbcDatabaseContainer {
public class OracleContainer extends JdbcDatabaseContainer<OracleContainer> {

public static final String NAME = "oracle";

Expand Down Expand Up @@ -81,13 +81,13 @@ public String getPassword() {
@Override
public OracleContainer withUsername(String username) {
this.username = username;
return this;
return self();
}

@Override
public OracleContainer withPassword(String password) {
this.password = password;
return this;
return self();
}

@SuppressWarnings("SameReturnValue")
Expand Down