Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement
dependsOn
for cross-container dependencies #1404Implement
dependsOn
for cross-container dependencies #1404Changes from all commits
3c0cc6a
3d48f79
68b2446
218ba9b
e35f0fc
af5f683
3295e5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure there's a good reason, but why do we not propagate a
stop()
call through the dependencies?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because there is no guarantee that the dependencies will be a part of the same "group".
We may introduce
deepStop
in futureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a
deepStop
would be useful for when you know these are the semantics you want. I end up having to manually create one in several projects. Thoughts on adding an API?Btw, are both
stop
andstart
required to be idempotent? I think the current implementation ofdeepStart
depends on this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just eyeballing the code, it looks like we're safe from circular dependencies, and also 'diamond' dependencies should be OK too.
Do you think it might be good to have tests for these scenarios in case a regression is introduced later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Circular dependencies won't work (we have "hard depends on")
I will add a test for the diamond case 👍