Presto: Bump default Presto version (used in deprecated constructor and unversioned JDBC URL) from 329 to 344 #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
changed the title
rnorth
requested changes
Oct 15, 2020
There was a problem hiding this comment.
This looks fine to me, but it seems that we have a test failure:
Gradle Test Executor 1 > org.testcontainers.containers.PrestoContainerTest > testSimple FAILED
org.junit.ComparisonFailure: Presto version expected:<3[43]> but was:<3[29]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.testcontainers.containers.PrestoContainerTest.testSimple(PrestoContainerTest.java:36)
I'd jump in and fix this myself but unfortunately don't have write permissions to the source branch.
findepi
force-pushed
the
presto-update
branch
from
0d4e219
to
61fe40c
Compare
findepi
changed the title
thanks, updated. |
rnorth
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2862
As #2992 showed, there is a value in updating the default (and tested) version.