Skip to content

Commit

Permalink
Presto: Bump default Presto version (used in deprecated constructor a…
Browse files Browse the repository at this point in the history
…nd unversioned JDBC URL) from 329 to 344 (#3312)
  • Loading branch information
findepi committed Oct 30, 2020
1 parent b94da0a commit 0ac9689
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/modules/databases/jdbc.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Insert `tc:` after `jdbc:` as follows. Note that the hostname, port and database

#### Using Presto

`jdbc:tc:presto:329://localhost/memory/default`
`jdbc:tc:presto:344://localhost/memory/default`

### Using a classpath init script

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class PrestoContainer<SELF extends PrestoContainer<SELF>> extends JdbcDat
public static final String NAME = "presto";
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("prestosql/presto");
public static final String IMAGE = "prestosql/presto";
public static final String DEFAULT_TAG = "329";
public static final String DEFAULT_TAG = "344";

public static final Integer PRESTO_PORT = 8080;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
import org.testcontainers.utility.DockerImageName;

public interface PrestoTestImages {
DockerImageName PRESTO_TEST_IMAGE = DockerImageName.parse("prestosql/presto:329");
DockerImageName PRESTO_PREVIOUS_VERSION_TEST_IMAGE = DockerImageName.parse("prestosql/presto:328");
DockerImageName PRESTO_TEST_IMAGE = DockerImageName.parse("prestosql/presto:344");
DockerImageName PRESTO_PREVIOUS_VERSION_TEST_IMAGE = DockerImageName.parse("prestosql/presto:343");
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class PrestoJDBCDriverTest extends AbstractJDBCDriverTest {
public static Iterable<Object[]> data() {
return asList(
new Object[][]{
{"jdbc:tc:presto:329://hostname/", EnumSet.of(Options.PmdKnownBroken)},
{"jdbc:tc:presto:344://hostname/", EnumSet.of(Options.PmdKnownBroken)},
});
}
}

0 comments on commit 0ac9689

Please sign in to comment.