Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC: Fix parsing empty connection parameters #2207

Merged
merged 1 commit into from Dec 27, 2019
Merged

JDBC: Fix parsing empty connection parameters #2207

merged 1 commit into from Dec 27, 2019

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Dec 22, 2019

No description provided.

rnorth
rnorth approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thanks for the PR - this looks good to me.

@rnorth rnorth added this to the next milestone Dec 27, 2019
@rnorth rnorth changed the title Fix parsing empty connection parameters JDBC: Fix parsing empty connection parameters Dec 27, 2019
@rnorth rnorth merged commit 4266fda into testcontainers:master Dec 27, 2019
@findepi findepi deleted the findepi/master/fix-parsing-empty-connection-parameters-dc93e6 branch December 27, 2019 20:08
@rui-ferreira rui-ferreira mentioned this pull request Jan 15, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
modules/jdbc resolution/acknowledged type/bug
Projects
None yet
Milestone
1.12.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@findepi @rnorth