Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention testcontainers-bom in "Maven dependencies" section of… #2178

Merged
merged 5 commits into from Dec 27, 2019
Merged

Mention testcontainers-bom in "Maven dependencies" section of… #2178

merged 5 commits into from Dec 27, 2019

Conversation

eaxdev
Copy link
Contributor

@eaxdev eaxdev commented Dec 14, 2019 •
edited

Issue #2134

rnorth
rnorth requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eaxdev - adding this is a good idea. I've suggested a few tweaks, but otherwise this looks good.

Thanks

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
eaxdev and others added 4 commits December 19, 2019 13:01
@eaxdev @rnorth
Update docs/index.md
bae4d38 
Co-Authored-By: Richard North <rich.north@gmail.com>
@eaxdev @rnorth
Update docs/index.md
291540d 
Co-Authored-By: Richard North <rich.north@gmail.com>
@eaxdev @rnorth
Update docs/index.md
dced2dc 
Co-Authored-By: Richard North <rich.north@gmail.com>
@eaxdev @rnorth
Update docs/index.md
22cdaf0 
Co-Authored-By: Richard North <rich.north@gmail.com>
@eaxdev
Copy link
Contributor Author

eaxdev commented Dec 19, 2019

Hello @rnorth. I accepted the suggested changes, see please.

@bsideup bsideup added this to the next milestone Dec 19, 2019
rnorth
rnorth approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @eaxdev!

@rnorth rnorth changed the title Mention testcontainers-bom in "Maven dependencies" section of the docs Mention testcontainers-bom in "Maven dependencies" section of… Dec 27, 2019
@rnorth rnorth merged commit f8cd923 into testcontainers:master Dec 27, 2019
@bsideup bsideup mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
1.12.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eaxdev @rnorth @bsideup