Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention testcontainers-bom in "Maven dependencies" section of the docs #2134

Closed
bsideup opened this issue Dec 2, 2019 · 3 comments
Closed

Mention testcontainers-bom in "Maven dependencies" section of the docs #2134

bsideup opened this issue Dec 2, 2019 · 3 comments
Labels
good first issue type/docs

Comments

@bsideup
Copy link
Member

bsideup commented Dec 2, 2019 •
edited

https://github.com/testcontainers/testcontainers-java/blob/master/docs/index.md should be updated and mention that here is org:testcontainers:testcontainers-bom that others can import to avoid specifying version of every dependency

Please reply to this issue first if you want to work on it.
@eaxdev
Copy link
Contributor

eaxdev commented Dec 14, 2019 •
edited

Hello @bsideup. I can do this issue.

@bsideup
Copy link
Member Author

bsideup commented Dec 14, 2019

thank you, @eaxdev! It is yours :)

@eaxdev eaxdev mentioned this issue Dec 15, 2019
Merged
rnorth added a commit that referenced this issue Dec 27, 2019
@eaxdev @rnorth
Mention testcontainers-bom in "Maven dependencies" section of… (#2178)
f8cd923 
* Mention testcontainers-bom in the Maven dependencies section of the docs #2134

* Update docs/index.md

Co-Authored-By: Richard North <rich.north@gmail.com>

* Update docs/index.md

Co-Authored-By: Richard North <rich.north@gmail.com>

* Update docs/index.md

Co-Authored-By: Richard North <rich.north@gmail.com>

* Update docs/index.md

Co-Authored-By: Richard North <rich.north@gmail.com>

Co-authored-by: Richard North <rich.north@gmail.com>
@testcontainers testcontainers deleted a comment from giuseppe23-max Mar 18, 2020
@bsideup
Copy link
Member Author

bsideup commented Jan 27, 2021

Fixed in #2178

@bsideup bsideup closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue type/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsideup @eaxdev