[Bugfix] Coordinate image removals after stopping containers

[aguibert]

I have been using ImageFromDockerFile to build images on the fly for my tests, which are supposed to be cleaned up by default.

However, I noticed that the images were being untagged and left as dangling images in most cases (see MicroShed/microshed-testing#9)

Currently Testcontianers registers shutdown hooks for:

• stopping and removing containers
• removing images

However, it does not coordinate these shutdown hooks. Typically the remove image hook fires before the stop+remove container hook completes, which leaves the dangling images. To solve this, we can merge the two shutdown hooks into one and therefore guarantee containers are stopped+removed before we attempt to do the image removal.

[rnorth]

Aha, thanks @aguibert. This looks very sensible. We probably should have consolidated much sooner.

I'll have a review and think about this, but on the face of it this seems fine.
Cheers

[bsideup]

Looks good to me, but will let @rnorth to review it as well (since he indicated an interest in it and may know some tricky details about it)

[rnorth]

Just to confirm, I'm happy with this 😄
Thanks once again @aguibert!

[minakh1993]

I have the same problem in version 1.17.5. defined image as below but after test execution created image is not removed.
new CmApplicationContainer(new ImageFromDockerfile().withDockerfile(Path.of(dockerfile)))
I checked the changed code in this commit. but changes doesn't seem to exist in 1.17.5 version(checked compiled class of ImageFromDockerfile resolve method). thanks in advance for your help.
update : an extra image is created out of nowhere that has no tag or name:
REPOSITORY TAG IMAGE ID CREATED SIZE
none none 888ca210c487 3 minutes ago 605MB

the main image that is created from imageFromDockerfile is removed correctly but this unknown image still exist after tests.
as i inspect the problem deeply this problem happen for multi-stage dockerfiles.

#6948