Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left over docker images #9

Closed
KyleAure opened this issue Aug 14, 2019 · 3 comments
Closed

Remove left over docker images #9

KyleAure opened this issue Aug 14, 2019 · 3 comments
Labels
is:bug Something isn't working

Comments

@KyleAure
Copy link
Collaborator

As a user of the system-test package, I would like to use the integration test capabilities of this package for test driven development. However, after performing an integration test, there is an un-tagged docker image left over (in this case liberty). These images should be cleaned up after tests are done.

kyleaure $  docker images
REPOSITORY                        TAG                 IMAGE ID            CREATED             SIZE
<none>                            <none>              4f9beb902785        27 seconds ago      454MB
<none>                            <none>              92665d6533e9        About an hour ago   454MB
<none>                            <none>              4bb455866900        About an hour ago   454MB
<none>                            <none>              0a836e010c64        About an hour ago   454MB
<none>                            <none>              610d278151d9        About an hour ago   454MB
@aguibert aguibert added the is:bug Something isn't working label Aug 14, 2019
@aguibert
Copy link
Member

I assume you are using the default new MicroProfileApplication() constructor here? If so, this should resolve using new ImageFromDockerfile(String dockerImage), which does delegate to ImageFromDockerfile(String dockerImageName, boolean deleteOnExit) with deleteOnExit=true.

The images should be getting cleaned up automatically by Testcontainers with the JVM shutdown hook they register, but I can see locally that's not happening for some reason.

@aguibert
Copy link
Member

Should be fixed by testcontainers/testcontainers-java#1745

@appiepollo14
Copy link
Collaborator

@KyleAure is this one still relevant?

@KyleAure KyleAure closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants