Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RabbitMQ module #1449

Merged
merged 26 commits into from Jul 16, 2019
Merged

Add RabbitMQ module #1449

merged 26 commits into from Jul 16, 2019

Conversation

martingreber
Copy link
Contributor

@martingreber martingreber commented May 3, 2019 •
edited by bsideup

Added RabbitMQContainer module so you can create a RabbitMQ container like this:

    RabbitMQContainer container = new RabbitMQContainer()
            .withExchange("direct-exchange", "direct")
            .withQueue("queue1")
            .withBinding("direct-exchange", "queue1");

Or with a more complex example:

    RabbitMQContainer container = new RabbitMQContainer()
            .withVhost("vhost1")
            .withVhostLimit("vhost1", "max-connections", 1)
            .withVhost("vhost2", true)
            .withExchange("direct-exchange", "direct")
            .withExchange("topic-exchange", "topic")
            .withQueue("queue1")
            .withQueue("queue2", true, false, ImmutableMap.of("x-message-ttl", 1000))
            .withBinding("direct-exchange", "queue1")
            .withUser("user1", "password1")
            .withUser("user2", "password2", ImmutableSet.of("administrator"))
            .withPermission("vhost1", "user1", ".*", ".*", ".*")
            .withPolicy("max length policy", "^dog", ImmutableMap.of("max-length", 1), 1, "queues")
            .withPolicy("alternate exchange policy", "^direct-exchange", ImmutableMap.of("alternate-exchange", "amq.direct"))
            .withOperatorPolicy("operator policy 1", "^queue1", ImmutableMap.of("message-ttl", 1000), 1, "queues")
            .withPluginsEnabled("rabbitmq_shovel", "rabbitmq_random_exchange");

#1447

@bsideup @martingreber
Update modules/rabbitmq/src/main/java/org/testcontainers/containers/R…
3c60e78 
…abbitMQContainer.java

Co-Authored-By: martingreber <31406507+martingreber@users.noreply.github.com>
chungngoops referenced this pull request in chungngoops/testcontainers-java May 5, 2019
@dependabot @rnorth
Bump assertj-core from 3.12.0 to 3.12.1 in /modules/neo4j (#1286)
a7eebda 
Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.12.0 to 3.12.1.
<details>
<summary>Commits</summary>

- [`8cc755f`](assertj/assertj@8cc755f) [maven-release-plugin] prepare release assertj-core-3.12.1
- [`14384ec`](assertj/assertj@14384ec) Avoid generating a module-info class. Fixes [#1448](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1448)
- [`fb75625`](assertj/assertj@fb75625) anySatisfy: do not continue evaluating elements once we found a match
- [`c8a6798`](assertj/assertj@c8a6798) fix a minor typo ([#1449](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1449))
- [`4e32776`](assertj/assertj@4e32776) Fail with error message if the given expectedStringTemplate is null ([#1450](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1450))
- [`2cba38f`](assertj/assertj@2cba38f) fix some more javadoc errors ([#1447](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1447))
- [`50e2e3a`](assertj/assertj@50e2e3a) Use String#join where possible
- [`fa94bf2`](assertj/assertj@fa94bf2) Javadoc fixes ([#1444](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1444))
- [`e3c2a57`](assertj/assertj@e3c2a57) Update Memory File System to 2.1.0
- [`2c57b2b`](assertj/assertj@2c57b2b) Fix javadoc and reenable Javadoc doclint verification ([#1438](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1438))
- Additional commits viewable in [compare view](assertj/assertj@assertj-core-3.12.0...assertj-core-3.12.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=org.assertj:assertj-core&package-manager=gradle&previous-version=3.12.0&new-version=3.12.1)](https://dependabot.com/compatibility-score.html?dependency-name=org.assertj:assertj-core&package-manager=gradle&previous-version=3.12.0&new-version=3.12.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
@martingreber
Copy link
Contributor Author

Hey guys, could you review the changes? All review comments have been addressed. Cheers!

@rnorth rnorth requested a review from bsideup May 7, 2019 11:42
rnorth
rnorth requested changes May 7, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice PR - thanks for the contribution. I've added a few very small comments, but nothing big!

modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java Outdated Show resolved Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java Outdated Show resolved Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java Outdated Show resolved Hide resolved
kkayri
kkayri reviewed May 7, 2019
View reviewed changes
Copy link

@kkayri kkayri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon soir mes amis je vous demande à quoi sert ces applications et comment les installer aux bureau

@martingreber
Copy link
Contributor Author

Hi guys, all resolved. Please review.

martin-greber
martin-greber suggested changes May 13, 2019
View reviewed changes
Copy link

@martin-greber martin-greber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rnorth, sorry these changes have already been applied on the branch, plus some bug fixes, so I think it's better to just look at commits on the branch itself.

@martingreber
Copy link
Contributor Author

Hey guys, any plans on merging this PR?

@rnorth rnorth self-requested a review May 18, 2019 21:09
@rnorth
Copy link
Member

rnorth commented May 18, 2019

Sorry @martingreber, we've all been tied up over the last few weeks. I'll aim to have a final re-review and merge tomorrow. Sorry for the delay.

@rnorth
Copy link
Member

rnorth commented May 28, 2019

FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503

bsideup
bsideup approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 will merge once CI is green 🎉

@bsideup bsideup added this to the next milestone Jul 16, 2019
@bsideup bsideup merged commit 30af86b into testcontainers:master Jul 16, 2019
@bsideup
Copy link
Member

bsideup commented Jul 16, 2019

CI is green (I did not count the unrelated failures to the CI problems we currently have)

@bsideup
Copy link
Member

bsideup commented Jul 16, 2019

@martingreber thanks for your contribution! Sorry that it took so long!

@bsideup bsideup changed the title Add rabbitmq Add RabbitMQ module Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkayri kkayri kkayri left review comments

@bsideup bsideup bsideup approved these changes

@martin-greber martin-greber martin-greber approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/new module
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@martingreber @rnorth @bsideup @kkayri @martin-greber @ennru