Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a minor typo #1449

Merged
merged 1 commit into from Feb 27, 2019
Merged

fix a minor typo #1449

merged 1 commit into from Feb 27, 2019

Conversation

epeee
Copy link
Member

@epeee epeee commented Feb 26, 2019

No description provided.

@joel-costigliola
Copy link
Member

Good catch, thanks!

@joel-costigliola joel-costigliola merged commit c8a6798 into assertj:master Feb 27, 2019
@joel-costigliola
Copy link
Member

Hey @epeee,

Would you be interested in becoming an Assertj Core commiter ? (and possibly other assertj projects too if you are keen)

You have been contributing a lot and your contributions are of high quality, you also pay attention to details (often more than me !), I think you would be awesome as a commiter !

I haven't had as much time to give to assertj lately so it is a good time to expand the Assertj team.

Here's how we will work (and how we work with Pascal Schumacher who is oart of the team):

  • no strings attached, if you have time to contribute, good, if not, no problem
  • I want to be involved in any AssertJ API changes
  • we discuss the main new features / improvements and AssertJ roadmap.
  • we don't have to discuss all your contributions, especially the refactoring ones, but if you want my opinion feel free to ask
  • if we disagree (which is ok), I'll have the final word, that's the advantage of being AssertJ benevolent dictator :)

I'm looking to hear what you think.
Cheers mate,

Joel

@epeee
Copy link
Member Author

epeee commented Feb 28, 2019

@joel-costigliola sure, I'd be interested.

Ad 'how we will work': sounds good!

@epeee epeee deleted the fix_typo branch February 28, 2019 04:34
@joel-costigliola
Copy link
Member

joel-costigliola commented Feb 28, 2019

Awesome, welcome to the team!

I have added you as a collaborator, let me know if you haven't received the invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants