Do not fail on duplicated local image tags. Fixes #2431 (#2692)

* #2431 Correction for an edge case in local image repos (duplicates repo tags) crashing the image pulling * Indentation correction * Indentation correction
testcontainers · May 13, 2020 · 123f13a · 123f13a
1 parent e6930d6
commit 123f13a
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/core/src/main/java/org/testcontainers/images/LocalImagesCache.java b/core/src/main/java/org/testcontainers/images/LocalImagesCache.java
@@ -79,10 +79,14 @@ private void populateFromList(List<Image> images) {
             }
 
             cache.putAll(
-                Stream.of(repoTags).collect(Collectors.toMap(
-                    DockerImageName::new,
-                    it -> ImageData.from(image)
-                ))
+                Stream.of(repoTags)
+                    // Protection against some edge case where local image repository tags end up with duplicates
+                    // making toMap crash at merge time.
+                    .distinct()
+                    .collect(Collectors.toMap(
+                        DockerImageName::new,
+                        it -> ImageData.from(image)
+                    ))
             );
         }
     }