Skip to content

Commit

Permalink
Deprecate Network.id field
Browse files Browse the repository at this point in the history
The field is deprecated in order to mark the NetworkBuildImpl#id method
deprecated so that the method can later be removed.  We'll undeprecate the
field at that time.
  • Loading branch information
quincy committed Jun 1, 2020
1 parent 53718af commit 0c4dcfb
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions core/src/main/java/org/testcontainers/containers/Network.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

public interface Network extends AutoCloseable, TestRule {

Network SHARED = new NetworkImpl(false, null, Collections.emptySet()) {
Network SHARED = new NetworkImpl(false, null, Collections.emptySet(), null) {
@Override
public void close() {
// Do not allow users to close SHARED network, only ResourceReaper is allowed to close (destroy) it
Expand All @@ -39,16 +39,10 @@ static NetworkImpl.NetworkImplBuilder builder() {
return NetworkImpl.builder();
}

@Builder
@Getter
class NetworkImpl extends ExternalResource implements Network {

@Builder
private NetworkImpl(Boolean enableIpv6, String driver, @Singular Set<Consumer<CreateNetworkCmd>> createNetworkCmdModifiers) {
this.enableIpv6 = enableIpv6;
this.driver = driver;
this.createNetworkCmdModifiers = createNetworkCmdModifiers;
}

private final String name = UUID.randomUUID().toString();

private Boolean enableIpv6;
Expand All @@ -58,6 +52,7 @@ private NetworkImpl(Boolean enableIpv6, String driver, @Singular Set<Consumer<Cr
@Singular
private Set<Consumer<CreateNetworkCmd>> createNetworkCmdModifiers;

@Deprecated
private String id;

private final AtomicBoolean initialized = new AtomicBoolean();
Expand Down

0 comments on commit 0c4dcfb

Please sign in to comment.