Allow numerical characters in example names/titles #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
previously approved these changes
Mar 7, 2023
|
@fbiville btw, could you update the docs with the |
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
approved these changes
Mar 7, 2023
|
Thanks @fbiville for your time making the module generation smarter! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR relaxes the requirement around example names and titles.
Names and titles cannot currently include any numbers, which is too limiting.
Why is it important?
This is important for products where numbers are included... like Neo4j :)
Related issues
This is a prerequisite for the Neo4j work initially discussed in #636, and isolated in #921.
How to test this PR
This should now work.