feature: custom ForSQL query

[funvit]

• a new setter added WithQuery

Closes #350

[mdelapenya]

This LGTM, thanks for taking the time to contribute it! I'd miss a test demonstrating the change, but other than that, great job!

[funvit]

Tests added.

[funvit]

So what to do with failed checks?

[mdelapenya]

So what to do with failed checks?

We have certain flakiness #411, but had no bandwidth to work on it yet. In any case, I re-ran your builds 🤞

[codecov]

Codecov Report

Merging #451 (7d1f6ff) into main (977ff3b) will increase coverage by 0.48%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   68.44%   68.93%   +0.48%     
==========================================
  Files          21       21              
  Lines        1892     1896       +4     
==========================================
+ Hits         1295     1307      +12     
+ Misses        480      472       -8     
  Partials      117      117              

Impacted Files	Coverage Δ
wait/sql.go	25.00% <80.00%> (+25.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977ff3b...7d1f6ff. Read the comment docs.

[funvit]

So what to do with failed checks?

We have certain flakiness #411, but had no bandwidth to work on it yet. In any case, I re-ran your builds crossed_fingers

Maybe merge my #455 at first?

[mdelapenya]

Great contribution, thanks!

[mdelapenya]

My only concern is about adding a dependency on Postgres, which is needed to tun the tests, but will be added to the project dependency on each client code running their tests with tc-go.

I understand the purpose of adding it, although I'd like to avoid adding that dependency. Do you foresee any solution for that?

[funvit]

My only concern is about adding a dependency on Postgres, which is needed to tun the tests, but will be added to the project dependency on each client code running their tests with tc-go.

I understand the purpose of adding it, although I'd like to avoid adding that dependency. Do you foresee any solution for that?

I can move TestContainerWithWaitForSQL to e2e directory and create there custom go.mod. This will remove dependency from main package.

After that gitlab CI file must be updated...

[mdelapenya]

Hey @gianarb I'd like you to take a deep look here because this PR comes with a submodule to avoid including postgres dependency as part of the project. And this is pretty related to the "canned" modules discussion we had in the past: #112

I'd appreciate your comments here

[gianarb]

I think in this case it is fine, there is a separate module and this is not a new feature but an enhancement for something we already support.