Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canned kafka #356

Conversation

franklinlindemberg
Copy link
Contributor

I had this code around and would love to have it somehow linked to testcontainers-go.

I created this PR only to be able to refer to it in modules documentation

@franklinlindemberg
Copy link
Contributor Author

franklinlindemberg commented Sep 26, 2021

Checks are failing because kafka_test is using confluent-kafka-go client, which is not supported on windows.

If anyone wants to use this on windows I suggest using a different go client

@gianarb
Copy link
Collaborator

gianarb commented Sep 30, 2021

Thanks! As you probably read in the documentation https://golang.testcontainers.org/modules/ we decided to avoid a proliferation of canned /modules container as part of this library to keep it light and easy to use (without many dependencies).

A possibility for you will be to maintain this code yourself in a repo and link it in our documentation so people interesting in ready to use kafka containers will relay on your work 👍

I am closing this for now!

@gianarb gianarb closed this Sep 30, 2021
@kernle32dll
Copy link

Just some shameless self-advertisement here. I got inspired by the code here, patched it up a bit (e.g. integrating TLS), and pushed into my own repository. Credit is given.
https://github.com/kernle32dll/testcontainers-go-canned

@eddumelendez
Copy link
Member

@kernle32dll there is a work in progress PR about adding examples. Check #618 and you may will to contribute. Our idea is to turn those examples to modules in the future.

@mdelapenya
Copy link
Collaborator

@kernle32dll we created #636, where you can find how to contribute new modules :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants