Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds k3s module #1194

Merged
merged 9 commits into from May 23, 2023
Merged

feat: adds k3s module #1194

merged 9 commits into from May 23, 2023

Conversation

mritunjaysharma394
Copy link
Contributor

@mritunjaysharma394 mritunjaysharma394 commented May 17, 2023 •
edited

What does this PR do?

This PR adds k3s modules for golang testcontainers

Why is it important?

It is important as part of a task of #636 to support k3s modules too.

Related issues

Relates to #636

@mritunjaysharma394
adds k3s module
6b5b8df 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
@mritunjaysharma394 mritunjaysharma394 requested a review from a team as a code owner May 17, 2023 14:43
@netlify
Copy link

netlify bot commented May 17, 2023 •
edited

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d3d22a5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/646c67b55117c10008f14871
😎 Deploy Preview https://deploy-preview-1194--testcontainers-go.netlify.app/modules/k3s
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdelapenya
mdelapenya reviewed May 17, 2023
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
mdelapenya
mdelapenya reviewed May 17, 2023
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
mdelapenya
mdelapenya reviewed May 17, 2023
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
@mritunjaysharma394
minor refactors
bdcd9e8 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
mdelapenya
mdelapenya reviewed May 17, 2023
View reviewed changes
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s_test.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@mritunjaysharma394
refactors in modules
7df98a7 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
@mritunjaysharma394
docs improvement
4121071 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
@mritunjaysharma394
Merge branch 'main' into k3-modules
ad668b0
mdelapenya
mdelapenya reviewed May 20, 2023
View reviewed changes
docs/modules/k3s.md Outdated Show resolved Hide resolved
mdelapenya
mdelapenya reviewed May 20, 2023
View reviewed changes
docs/modules/k3s.md Outdated Show resolved Hide resolved
@mritunjaysharma394
minor fixes in docs
be4fdbe 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
@mritunjaysharma394
ran go mod tidy for k3s modules
801188a 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
mdelapenya
mdelapenya reviewed May 22, 2023
View reviewed changes
modules/k3s/k3s.go Outdated Show resolved Hide resolved
@mritunjaysharma394
nit: improved method name
9ecd81c 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
mdelapenya
mdelapenya reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll have a better docs experience including the suggestions I added in the docs.

Hopefully, this change will be the last one 🤞 so this PR will be ready to be merged

docs/modules/k3s.md Outdated Show resolved Hide resolved
docs/modules/k3s.md Show resolved Hide resolved
modules/k3s/k3s.go Outdated Show resolved Hide resolved
@mritunjaysharma394
improvements in docs
d3d22a5 
Signed-off-by: Mritunjay <mritunjaysharma394@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mritunjaysharma394
Copy link
Contributor Author

Thanks a lot @mdelapenya for the amazing reviews and suggestions, just improved the doc as suggested, let's hope it looks good now, ping me for any other improvements 🙏

@mdelapenya mdelapenya self-assigned this May 23, 2023
@mdelapenya mdelapenya added the enhancement New feature or request label May 23, 2023
@mdelapenya mdelapenya changed the title adds k3s module feat: adds k3s module May 23, 2023
mdelapenya
mdelapenya approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution and for your patience while reviewing it

@mdelapenya mdelapenya merged commit bfd7304 into testcontainers:main May 23, 2023
58 checks passed
@mdelapenya mdelapenya mentioned this pull request May 23, 2023
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mritunjaysharma394 @mdelapenya