Add support for Emqx Container #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will take a look at it :) Thanks for the contribution |
jarlah
requested changes
Apr 21, 2024
jarlah
reviewed
Apr 26, 2024
| @@ -0,0 +1,48 @@ | |||
| defmodule Testcontainers.Container.EmqxContainerTest do | |||
There was a problem hiding this comment.
you aren't actually doing stuff with the container. Do you think we should add a test to verify we can actually use the emqx container for something "useful" ?
There was a problem hiding this comment.
Good idea. I will try and come up with something.
There was a problem hiding this comment.
rebase and fix conflicts. and i can merge it with and you can add test later in a second PR, if you agree
jarlah
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.