Merge branch 'klassm-fork/eslint8' into eslint8

testcafe-community · Oct 30, 2021 · 8717cc3 · 8717cc3
2 parents 78e9049 + cadf662
commit 8717cc3
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -47,6 +47,7 @@ module.exports = {
                     { devDependencies: true }
                 ],
                 "no-console": "off",
+                "@typescript-eslint/no-unsafe-argument": "off",
                 "@typescript-eslint/no-non-null-assertion": "off" // Tests should throw errors, jest will catch them
             }
         },

diff --git a/lib/rules/expect-expect.ts b/lib/rules/expect-expect.ts
@@ -35,7 +35,6 @@ export default createRule({
         },
         docs: {
             description: "Ensure tests have at least one expect",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-debug.ts b/lib/rules/no-debug.ts
@@ -23,7 +23,6 @@ export default createRule({
         docs: {
             description:
                 "Don't allow `t.debug()` to be committed to the repository. ",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-identical-title.ts b/lib/rules/no-identical-title.ts
@@ -60,7 +60,6 @@ export default createRule({
         },
         docs: {
             description: "Don't use identical titles for your tests",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-only.ts b/lib/rules/no-only.ts
@@ -21,7 +21,6 @@ export default createRule({
         docs: {
             description:
                 "Don't allow `test.only` to be added to the repository",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-skip.ts b/lib/rules/no-skip.ts
@@ -17,11 +17,10 @@ export default createRule({
         messages: {
             noSkip: "Do not use the `.skip` hook."
         },
-        type: "suggestion",
+        type: "problem",
         docs: {
             description:
                 "Don't allow `test.skip` or `fixture.skip` to be added to the repository",
-            category: "Best Practices",
             recommended: "warn"
         },
         schema: []

diff --git a/tests/lib/index.test.ts b/tests/lib/index.test.ts
@@ -38,7 +38,6 @@ describe("Rule Definitions", () => {
             const rule = rulebook.rules[ruleName];
             expect(rule).toHaveProperty("create", expect.any(Function));
             expect(rule.meta.docs?.url).not.toBeEmpty();
-            expect(rule.meta.docs?.category).toBe("Best Practices");
             expect(rule.meta.docs?.description).not.toBeEmpty();
         }
     );