Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify the config #191

Merged
merged 1 commit into from May 28, 2020
Merged

Explicitly specify the config #191

merged 1 commit into from May 28, 2020

Conversation

pirj
Copy link
Contributor

@pirj pirj commented May 26, 2020 •
edited

rubocop/rubocop#7970 in RuboCop 0.84 mixes in the default config, which changes the config options from "default" (missing) false to actual true from config/defaults.yml

Checklist

  • [-] I've added tests for this change
  • [-] I've added a Changelog entry
  • [-] I've updated a documentation

@pirj
Explicitly specify the config
524fc04 
rubocop/rubocop#7970 in RuboCop 0.84
mixes in the default config, which changes the config options from
"defult" (missing) `false` to actual `true` from config/defaults.yml
@pirj pirj mentioned this pull request May 26, 2020
Merged
palkan
palkan approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@palkan palkan merged commit 4d6a1d0 into test-prof:master May 28, 2020
@pirj pirj deleted the update-to-follow-new-cop-config-testing-way branch May 28, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan palkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pirj @palkan