update debug logs to mask password #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
vkarve-chef
requested review from
tas50,
damacus,
kasif-adnan and
sanjain-progress
kasif-adnan
approved these changes
Jul 4, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vikram Karve vikram.karve@progress.com
Description
The transport debug logs include password in cleartext. The password have either been omitted or masked in the log.
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List