Compress more nullish checks into nullish coalescing #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for `foo != null ? foo : bar` (and the respective `!==` checks). This is particularly important because Babel outputs this form of nullish coalescing.
| OR | ||
| ? !(cmp.operator === "===" || cmp.operator === "==") | ||
| : !(cmp.operator === "!==" || cmp.operator === "!=") | ||
| ) { |
| left: alternative, | ||
| right: consequent | ||
| left: left, | ||
| right: left == alternative ? consequent : alternative, | ||
| }).optimize(compressor); |
There was a problem hiding this comment.
I guess is_nullish_check could return the left and right hand side:
const nullish_check = get_nullish_check(condition, consequent, alternative, compressor);
if (nullish_check != null) { // very meta line here
const [left, right] = nullish_check
// create "??" expression using left and right
}
|
I'm confused as to why the functional tests don't run. Maybe there's a test in react that uses document.all? 🤔 |
|
I don't think it's |
|
Oh, I think I know what it is then. What we're running the tests on is node 12 (one of the applications under test requires it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
foo != null ? foo : bar(and the respective!==checks). This is particularly important because Babel outputs this form of nullish coalescing.