Revert "Revert "Fix compressed source-maps have non-terminated segments"" #382
Conversation
|
@fabiosantoscode can we do this asap webpack-contrib/terser-webpack-plugin#100? |
|
@evilebottnawi the fix is in 4.0.2. This PR is to put back the feature that created the issue in 4.0.1, as soon as mozilla/source-map#385 gets a fix. |
|
Thanks @fabiosantoscode for trying to get this fixed again once the root cause issue on |
|
NP @devversion but we won't be integrating the new source-map version. There's been talk on another issue, #385, regarding the fact that it isn't sync anymore. We have to use something else for sourcemaps as terser is not going to become async anytime soon :( |
2 similar comments
|
NP @devversion but we won't be integrating the new source-map version. There's been talk on another issue, #385, regarding the fact that it isn't sync anymore. We have to use something else for sourcemaps as terser is not going to become async anytime soon :( |
|
NP @devversion but we won't be integrating the new source-map version. There's been talk on another issue, #385, regarding the fact that it isn't sync anymore. We have to use something else for sourcemaps as terser is not going to become async anytime soon :( |
fabiosantoscode
force-pushed
the
master
branch
2 times, most recently
from
b95514a
to
e140ce9
Compare
|
@fabiosantoscode I was looking at the Mozilla issue again and I'm actually surprised this was reported on mozilla's side. It seems like the source validation is correct there, and also the source map generation from Terser side is correct. I assume back then this was/still is? an issue from the webpack generation: mozilla/source-map#385 (comment) |
|
I've sent #1106 which resolves the conflicts + fixes the test to actually be more correct + adds a test assertion that ensures that |
Reverts #381, which is a revert of #342
Context:
The #342 PR was reverted to quickly work around a bug caused by source-map.
Merge this when mozilla/source-map#385 is closed.