lhs_constants option for #1359
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccir
commented
Mar 26, 2023
| @@ -2174,6 +2178,19 @@ def_optimize(AST_Binary, function(self, compressor) { | |||
| self.left = make_node(AST_Undefined, self.left).optimize(compressor); | |||
| if (self.operator.length == 2) self.operator += "="; | |||
| } | |||
| } else if (compressor.option("typeofs") | |||
There was a problem hiding this comment.
This block of code is only applicable for comparisons: true, typeofs: true, lhs_constants: false. I'm not sure if the added complexity is worth it.
iccir
commented
Mar 26, 2023
| @@ -12,6 +12,7 @@ asm_mixed: { | |||
| join_vars: true, | |||
| keep_fargs: true, | |||
| keep_fnames: false, | |||
| lhs_constants: true, | |||
There was a problem hiding this comment.
When a test case already had several true options, I didn't mind adding lhs_constants: true.
iccir
commented
Mar 26, 2023
| @@ -182,11 +182,11 @@ static_means_execution: { | |||
| let x = 0; | |||
| // Does not get inlined as it contains an immediate side effect | |||
| class WithStaticProps { | |||
| static prop = (x = 0 === x ? 1 : "FAIL") | |||
There was a problem hiding this comment.
In this case, I opted to move the 0 back to the right-hand side. This test case is testing code unrelated to comparisons.
|
Nicely done, thanks! I'll release during the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a new option called
lhs_constantswhich defaults totrue. I thought about havingcomparisons: falseturn off left-hand side constants, but didn't like this as non-comparison operators (*,&,|,^) are also affected.That said, several
comparisonsoptimizations assumelhs_constants: true. I tried to decouple the two, but I could use some guidance: should we add more complexity incompress/index.jsto allowcomparisons: true, lhs_constants: false? My assumption is that most people will either want bothtrueor bothfalse.I audited all failing test cases. I added
lhs_constants: truefor those which tested comparisons (or those that already had several other options set totrue). When a test case focused on non-comparison optimizations, I reversed the order in the expected result.