Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update commander #1339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update commander #1339

wants to merge 2 commits into from

Conversation

243083df
Copy link

@243083df 243083df commented Feb 4, 2023

No description provided.

@243083df
Copy link
Author

243083df commented Feb 4, 2023

All test passed on my machine. :D
Not sure about package-lock.json upgdare :C
Not commander 10, because since commander 9 they bump node version requirement and not align with terser node requirement.

Comment on lines +514 to +516
"engines": {
"node": ">= 12"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commander requirement might be an issue. The tests pass, but I'm not sure if people will be unable to install Terser with their package manager because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants