Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the places where code is built as a string and then evaled to make a function. This improves compatibility with runtimes where eval is banned.
The codeshift does the minimal set of changes to make this work, and I have manually fixed a couple of things after running the codeshift.
The source for the codeshift is here: https://github.com/sgoo/ast-fixer
I did have a go at replacing the calls to DEFNODE with
class
declarations, I got the code to run, but I got test failures where the minified output was slightly wrong, I'm not sure what caused that.My results from that attempt are here: sgoo/ast-fixer@f77472e
Fixes #925