WIP: fix: don't drop side effects of default param assignments #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
param-default-assign-side-effects
branch
3 times, most recently
from
044fcc3
to
20f72c3
Compare
WofWca
force-pushed
the
param-default-assign-side-effects
branch
from
20f72c3
to
f4201be
Compare
| arg.is_boolean() | ||
| || arg.is_number() | ||
| || arg.is_string() | ||
| ); |
There was a problem hiding this comment.
I think it's best to create a is_not_undefined in compress/inference.js and use that. This way there's no implicit dependency between is_constant and !is_undefined that needs to be maintained and remembered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #880
Here's my draft, finally. It is said in #880 (comment) that there's lots of places that need changes related to #880, but this only touches one - function call drops (but even this should be taken with a grain of salt - I'm not super experienced with this stuff).
Hopefully it can still be of use.