make is_constant() recognize constants with several unary prefixes
#1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. previously it would return `false` for expressions like `void !0`
jridgewell
reviewed
Feb 7, 2022
|
Do you have an idea where to put it? Because this function looks rather internal. Best I can think of right now is adding something like |
|
You're right, after looking into the codebase there's not a great spot. The only one that I can see is in BinaryExpression, but it won't be a great test case regardless. This change could be merged into #1141 since that's the only observable case so far. |
|
Maybe then it's better to just merge this and #1141 first, then add a test? |
|
Sounds like a good plan @WofWca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. previously it would return
falsefor expressions likevoid !0