Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen requirements discovering identity functions #1121

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Loosen requirements discovering identity functions #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f567efd
modify test cases, found the problem spot
samouri Nov 29, 2021
be66ddc
new test in proper spot -- expand understanding of identity fn.
samouri Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/compress/index.js
View file
Open in desktop
Expand Up @@ -2375,9 +2375,7 @@ def_optimize(AST_Call, function(self, compressor) {
}

// optimize identity function
if (
fn.argnames.length === 1
&& (fn.argnames[0] instanceof AST_SymbolFunarg)
if (fn.argnames[0] instanceof AST_SymbolFunarg
&& self.args.length < 2
&& returned instanceof AST_SymbolRef
&& returned.name === fn.argnames[0].name
Expand Down
13 changes: 13 additions & 0 deletions test/compress/identity.js
View file
Open in desktop
Expand Up @@ -249,3 +249,16 @@ inline_identity_dont_lose_this_when_arg: {
}
}

inline_identity_with_scope_conflict: {
options = { defaults: true, toplevel: true }
input: {
function identity(a, _b, _c, _d) {
return a;
}
console.log(identity(a));
}

expect: {
console.log(a);
}
}