Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compress/eval of optional chains #1062

Merged
merged 6 commits into from Sep 19, 2021
Merged

Fix compress/eval of optional chains #1062

merged 6 commits into from Sep 19, 2021

Commits on Sep 13, 2021

  1. Fix compress/eval of optional chains 

    This implements the recursion necessary to determine if a property access/call is part of an optional chain that has short-circuited.
    @jridgewell
    jridgewell committed Sep 13, 2021
    Copy the full SHA
    9eac7c2 View commit details
    Browse the repository at this point in the history

  2. fix evaluation of chain

    @jridgewell
    jridgewell committed Sep 13, 2021
    Copy the full SHA
    7418170 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Fábio Santos <fabiosantosart@gmail.com>
    @jridgewell @fabiosantoscode
    jridgewell and fabiosantoscode committed Sep 13, 2021
    Copy the full SHA
    e7a4b72 View commit details
    Browse the repository at this point in the history

  4. Add test cases for future optional chain dropping

    @jridgewell
    jridgewell committed Sep 13, 2021
    Copy the full SHA
    f76cdb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Only drop expression if optional chaining is used

    @jridgewell
    jridgewell committed Sep 16, 2021
    Copy the full SHA
    c3d7f15 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. Ensure nullish is never returned from evaluate

    @jridgewell
    jridgewell committed Sep 19, 2021
    Copy the full SHA
    ad43909 View commit details
    Browse the repository at this point in the history