Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terser for Gulp #1023

Closed
wants to merge 3 commits into from
Closed

Terser for Gulp #1023

wants to merge 3 commits into from

Conversation

brendan8c
Copy link
Contributor

I wrote some code that allows to use the 'terser' plugin in the 'gulp' build.
There is no longer any need to use additional plugins for this.

I wrote some code that allows to use the 'terser' plugin in the 'gulp' build.
There is no longer any need to use additional plugins for this.
(Added changes. Changed the name of the functions.)
I wrote some code that allows to use the 'terser' plugin in the 'gulp' build.
There is no longer any need to use additional plugins for this.
@fabiosantoscode
Copy link
Collaborator

Hello!

Thanks for this. Could you add error handling to this plugin? The minify function throws syntax errors and other failures. Also this should probably be in a RECIPES.md file

@brendan8c
Copy link
Contributor Author

Привет!

Спасибо за это. Не могли бы вы добавить в этот плагин обработку ошибок? Функция minify выдает синтаксические ошибки и другие сбои. Также это, вероятно, должно быть в файле RECIPES.md.

Yes, I will try to do it.

Added error handling
@brendan8c
Copy link
Contributor Author

brendan8c commented Jul 17, 2021

Added error handling.
I don't understand where this file (RECIPES.md) is, I did not find it.

@fabiosantoscode
Copy link
Collaborator

It should be a new file, linked from the README.md.

I'll make sure it shows up in a new section on terser.org too, there's a script that syncs it with the readme and I'll just need to add the recipes to that script.

@brendan8c
Copy link
Contributor Author

It should be a new file, linked from the README.md.

I'll make sure it shows up in a new section on terser.org too, there's a script that syncs it with the readme and I'll just need to add the recipes to that script.

I have never done this and have not found information on the Internet.
Do I need to create a RECIPES.md file in the root of this repo and put what I wrote in the README.md file there?
Please tell us in more detail.

@fabiosantoscode
Copy link
Collaborator

Yes, do place it in a RECIPES.md. I'll handle the rest

@brendan8c
Copy link
Contributor Author

Yes, do place it in a RECIPES.md. I'll handle the rest

I did it, I hope everything is correct.
RECIPES.md

@fabiosantoscode
Copy link
Collaborator

Merged in #1035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants