fix typings #779
Merged
fix typings #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves terser#777 - Removed `AST_Node` references - Changed `comments(node, comment)` option so `node` is an any - Removed `ast` property from `MinifyOutput` - Removed `async` modifier
L2jLiga
approved these changes
Aug 9, 2020
1 task
alan-agius4
approved these changes
Aug 11, 2020
|
Cool, thanks! Sorry about the bad typings. I don't test these so as to not bloat the node_modules while I work. |
|
Can we get a new release here :) ? |
|
Thanks @adamdbradley! 👏 @fabiosantoscode when we can expect a new release? Thanks in advance! |
|
I was planning to release earlier this week but somehow I forgot. I'll release shortly |
|
Great, thanks @fabiosantoscode! |
|
5.1.0 is out! Sorry about my terrible memory :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #777
AST_Nodereferencescomments(node, comment)option sonodeis an anyastproperty fromMinifyOutputasyncmodifier