chore: update rollup-plugin-terser #1805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdonrd
force-pushed
the
update-rollup-plugin-terser
branch
2 times, most recently
from
a5efea6
to
f077afc
Compare
|
Depends on new relase with: terser/terser#779 |
abdonrd
force-pushed
the
update-rollup-plugin-terser
branch
from
5cdbfcf
to
7820e46
Compare
abdonrd
force-pushed
the
update-rollup-plugin-terser
branch
from
7820e46
to
17bd93c
Compare
abdonrd
force-pushed
the
update-rollup-plugin-terser
branch
from
17bd93c
to
f7ca716
Compare
abdonrd
force-pushed
the
update-rollup-plugin-terser
branch
3 times, most recently
from
0737f19
to
e8199bf
Compare
|
Now terser.minify is async, we need to update it. https://github.com/terser/terser/blob/master/CHANGELOG.md#v500-beta0 |
|
This is definitely going to be a bit of a pain to rewrite :( |
|
Thanks a lot of this PR. Upgrading terser will be a bit more complex, but I don't want to block that updating the rollup plugin so I'm doing that upgrade in #1831. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v5 depends on a version of
serialize-javascriptwith a vulnerability:https://github.com/IBM/pwa-lit-template/network/alert/package-lock.json/serialize-javascript/open