-
-
Notifications
You must be signed in to change notification settings - Fork 374
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't mangle computed properties with keep_quoted (#1058)
* Preserve computed attributes when mangling with keep_quoted There were various failures when using computed properties with property mangling enabled with `keep_quoted`: ```js // keep_quoted: true let prop = '_foo'; let o = { [prop]: 'bar' }; console.log(o[id('_foo')]); // - - - let prop = '_foo'; let o = { [prop]() { return 'bar' } }; console.log(o[id('_foo')]()); // - - - let prop = '_foo'; let o = { get [prop]() { return 'bar' } }; console.log(o[id('_foo')]); ``` ```js // keep_quoted: 'strict' let prop = '_foo'; let o = { [prop]: 'bar' }; console.log(o[id('_foo')]); ``` * Add tests for strict/loose keep_quotes actually reserving names * Unskip tests
- Loading branch information
1 parent
748e3a6
commit 3409eb6
Showing
7 changed files
with
1,680 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.