Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-5331 Show loading page when determining module projects #2607

Merged
merged 2 commits into from
May 13, 2024
Merged

SW-5331 Show loading page when determining module projects #2607

merged 2 commits into from
May 13, 2024

Conversation

tommylau523
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terraware-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 10:57pm
tree-location-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 10:57pm

@tommylau523 Graphite App
Copy link
Contributor Author

tommylau523 commented May 10, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on Graphite Graphite

@tommylau523 tommylau523 changed the title Show loading page when determining module projects SW-5331 Show loading page when determining module projects May 10, 2024
@tommylau523 tommylau523 mentioned this pull request May 10, 2024
Merged
@tommylau523 tommylau523 marked this pull request as ready for review May 10, 2024 18:10
@tommylau523 tommylau523 requested a review from a team as a code owner May 10, 2024 18:10
nickgraz
nickgraz approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@nickgraz nickgraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one small suggestion

@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-flashes branch from 1002a4f to 78791e1 Compare May 10, 2024 23:23
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-loading branch from f2c1a01 to 98f4aa3 Compare May 10, 2024 23:23
@tommylau523 tommylau523 mentioned this pull request May 10, 2024
Merged
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-flashes branch from 78791e1 to e40f310 Compare May 13, 2024 22:24
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-loading branch from 98f4aa3 to b762925 Compare May 13, 2024 22:24
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-flashes branch from e40f310 to 7d7e188 Compare May 13, 2024 22:25
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-loading branch from b762925 to d833bb5 Compare May 13, 2024 22:25
@tommylau523 Graphite App
Copy link
Contributor Author

tommylau523 commented May 13, 2024 •
edited

Merge activity

  • May 13, 6:44 PM EDT: @tommylau523 started a stack merge that includes this pull request via Graphite.
  • May 13, 6:46 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 13, 6:55 PM EDT: @tommylau523 merged this pull request with Graphite.

Base automatically changed from tommylau/sw-5331-home-screen-flashes to main May 13, 2024 22:45
@tommylau523 tommylau523 force-pushed the tommylau/sw-5331-home-screen-loading branch from d833bb5 to 9c658b8 Compare May 13, 2024 22:45
@tommylau523 tommylau523 merged commit 9434e4a into main May 13, 2024
3 of 5 checks passed
@tommylau523 tommylau523 deleted the tommylau/sw-5331-home-screen-loading branch May 13, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickgraz nickgraz nickgraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tommylau523 @nickgraz