Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer: Bump to release 2021-09-13 #7547

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

shadmansaleh
Copy link
Contributor

No description provided.

@shadmansaleh shadmansaleh marked this pull request as draft September 16, 2021 16:23
@shadmansaleh
Copy link
Contributor Author

shadmansaleh commented Sep 16, 2021

Anyone with experience in rust ?

Compiling hir_ty v0.0.0 (/home/builder/.termux-build/rust-analyzer/src/crates/hir_ty)
error[E0658]: use of unstable library feature 'control_flow_enum': new API
 --> crates/hir_ty/src/method_resolution.rs:5:17
  |
5 | use std::{iter, ops::ControlFlow, sync::Arc};
  |                 ^^^^^^^^^^^^^^^^
  |
  = note: see issue #75744 <https://github.com/rust-lang/rust/issues/75744> for more information

Does this mean rust nightly compiler is required to compile this ?

@shadmansaleh
Copy link
Contributor Author

shadmansaleh commented Sep 16, 2021

Well can't really enable unstable features in stable compiler .

Looks like the type ops::ControlFlow was stabilized in rust-lang/rust#85608 .We have newer rust compiler than that right ?

Edit:
No we don't it was released in 1.55.0 we have 1.53.0 so this wont compile until rust is bumped to 1.55.0

1.55 was released a week ago and since upgrading to 1.54 failed I think this pr will remain draft for a while.

@ghost ghost added the WIP Work in progress, do not close the issue (PR). label Sep 24, 2021
@shadmansaleh
Copy link
Contributor Author

shadmansaleh commented Oct 26, 2021

Any idea why result of

curl -s fileurl | sha256sum

is different different then

curl -Lo file fileurl
sha256sum file

??

How do you get sha256 of file for package ?

@shadmansaleh shadmansaleh marked this pull request as ready for review October 26, 2021 14:24
@shadmansaleh shadmansaleh requested a review from a user October 26, 2021 14:24
@ghost
Copy link

ghost commented Oct 26, 2021

How do you get sha256 of file for package ?

cd ./packages/${YOUR_PACKAGE}
(source build.sh 2>/dev/null; curl -LO "$TERMUX_PKG_SRCURL")
sha256sum "file"

Use -L for curl because of possible redirects.

You may also use script ./scripts/bin/update-checksum

@shadmansaleh
Copy link
Contributor Author

@xeffyr Thanks . That makes sense it wasn't getting redirected.

One off topic question . Is there a way to disable a step for a package . For example I'm trying to build a c/cpp program . You just need to run make and configure step makes no sense and causes the build to fail . Can I some how say the builder to skip configure and just run the make step ?

@ghost
Copy link

ghost commented Oct 26, 2021

Can I some how say the builder to skip configure and just run the make step ?

Just define empty configure step

termux_step_configure() {
	:
}

@shadmansaleh
Copy link
Contributor Author

For now lets keep auto_update out of this pr since it'll require changes to core scripts and possibly to other packages too depending on how we do it .

This can be merged without it.

@thunder-coding thunder-coding removed the WIP Work in progress, do not close the issue (PR). label Oct 28, 2021
@thunder-coding thunder-coding merged commit f092570 into termux:master Oct 28, 2021
@shadmansaleh shadmansaleh deleted the bump/rust-analyzer branch October 28, 2021 12:40
metayan pushed a commit to metayan/termux-packages that referenced this pull request Nov 28, 2021
* Bump rust-analyzer to release 2021-10-25

* For now drop auto_update. Will tackle it later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants