Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(main): new package esbuild #11895

Closed
wants to merge 1 commit into from
Closed

Conversation

2096779623
Copy link
Member

Close #11873 .

@ravener
Copy link
Member

ravener commented Sep 12, 2022

  1. Why are you doing termux_setup_nodejs Node is not needed.
  2. Why are you blacklisting arm?

@2096779623
Copy link
Member Author

2096779623 commented Sep 12, 2022

@2096779623
Copy link
Member Author

@ravener
Copy link
Member

ravener commented Sep 12, 2022

That is really weird cause it builds on arm without issues on-device, I don't know what is esbuild doing differently from other packages which termux cross-compiles all the time.

@ravener
Copy link
Member

ravener commented Sep 12, 2022

Can you perhaps try what is mentioned here? golang/go#48246 (comment)

Edit: Actually in termux's build context, CC should already be set, right?

@2096779623 2096779623 marked this pull request as draft September 12, 2022 04:26
@2096779623
Copy link
Member Author

2096779623 commented Sep 12, 2022

Edit: Actually in termux's build context, CC should already be set, right?

CC is not passed in the Makefile, it needs to be set manually.

Edit: Same result.

@ravener
Copy link
Member

ravener commented Sep 12, 2022

Edit: Actually in termux's build context, CC should already be set, right?

CC is not passed in the Makefile, it needs to be set manually.

Really? All other packages that invoke a makefile, never passes CC it's probably set by the package builder.

Edit: Same result.
Ah too bad. I'm running out of ideas.

@2096779623 2096779623 force-pushed the esbuild branch 5 times, most recently from 1bf9ab0 to b6cfd1e Compare October 23, 2022 04:05
Signed-off-by: 2096779623 <admin@utermux.dev>
Co-authored-by: Yaksh Bariya <yakshbari4@gmail.com>
@ravener
Copy link
Member

ravener commented Nov 10, 2022

@2096779623 hi, it's been a while. I tried to look into this and I found something that could be fixed.

Try removing the CGO_ENABLED=0 from the makefile target, since the issue here was a cgo issue and cgo is disabled in the first place!

Additionally to clean up the code:

  • Remove CC=${cc} should not be needed.
  • Remove all the GOOS and GOARCH trickery, just running make should be enough.

This should hopefully get the arm build fixed and we can move on with this package.

@ravener
Copy link
Member

ravener commented Dec 4, 2022

Closing this because someone else already added the package.

@ravener ravener closed this Dec 4, 2022
@2096779623 2096779623 deleted the esbuild branch January 12, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package]: esbuild
2 participants