-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FullyConnected layer integration changes #2491
base: main
Are you sure you want to change the base?
Conversation
1) Integration of float32, 4-bit & 16-bit fully_connected kernels. 2) Integration of matmul kernels for float32, 4, 8, 16-bit batched fully_connected cases. 3) Data-type based registration for fully_connected operator. 4) Addition of compile flag to include / exclude HiFi floating point optimized fully_connected kernel.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, but one minor comment and the code formatting needs to be fixed. I tried to do it, but I don't have permissions to modify the branch.
const TfLiteEvalTensor* input, const TfLiteEvalTensor* filter, | ||
const TfLiteEvalTensor* bias, TfLiteEvalTensor* output) { | ||
|
||
#if defined(INCLUDE_FLOAT_OPT) && (defined(HIFI4) || defined(HIFI5)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add define for HIFI3.
@vp-cad - The formatting errors can be fixed with:
|
Following changes have been made :
BUG=none