Fix Arm Virtual Hardware CI workflow #2479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasHertel80
requested review from
advaitjain,
rockyrhodes,
rascani and
a team
as code owners
rascani
approved these changes
Feb 28, 2024
rascani
reviewed
Mar 7, 2024
| on: | ||
| schedule: | ||
| - cron: '0 4 * * *' | ||
| on: [push, pull_request] |
There was a problem hiding this comment.
As written, this will run on every push to any branch and on every PR event. I'm going to revise this to a more narrow subset. I'm thinking ci:run_full and postmerge makes sense for this.
There was a problem hiding this comment.
Mans: this could probably be run pre-merge.
There was a problem hiding this comment.
@MatthiasHertel80 - I can't modify your main branch, so I can't update this myself. I'm going to suggest this:
on:
# Allow manually triggering of the workflow.
workflow_dispatch: {}
workflow_call:
inputs:
trigger-sha:
required: true
type: string
secrets:
tflm-bot-token:
required: true
I want to test it out in CI first, then start requiring it for PRs.
|
"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing tests for Cortex-M and Arm Compiler 6 use Arm Virtual Hardware instances on AWS. Same function is now supplied in a docker image available on the Github Container Registry, allowing to execute tests directly on GH runners.
The image:
docker pull ghcr.io/arm-software/avh-mlops/arm-mlops-docker-licensed-community:latest