Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth check for dilation2d #7137

Merged
merged 1 commit into from Dec 2, 2022
Merged

Conversation

Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Dec 2, 2022

Fix #7112

According to tensorflow, the last dimension of input and the last dimension of filter are depth and they are supposed to have the same size, otherwise an error would be thrown:
Screen Shot 2022-12-01 at 5 06 54 PM

So, we also want to throw an error if the depths of input and filter do not match.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@Linchenn Linchenn merged commit 4314334 into tensorflow:master Dec 2, 2022
@Linchenn Linchenn deleted the fixDilation2D branch December 2, 2022 01:58
Linchenn added a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants