webgpu: support linSpace operator #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
approved these changes
Nov 29, 2022
| export const linSpaceConfig: KernelConfig = { | ||
| kernelName: LinSpace, | ||
| backendName: 'webgpu', | ||
| kernelFunc: linSpace as {} as KernelFunc |
There was a problem hiding this comment.
nit: Per #7116, use as unknown as KernelFunc.
There was a problem hiding this comment.
Could we submit a CL to change all kernels, not modify only one here?
xhcao
force-pushed
the
linSpace
branch
2 times, most recently
from
e45ec11
to
53a2cdb
Compare
gyagp
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is