Refactor type conversion for read back #7044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axinging
force-pushed
the
checkTypedArrayName
branch
2 times, most recently
from
d9e4e0c
to
1a59012
Compare
axinging
changed the title
axinging
force-pushed
the
checkTypedArrayName
branch
3 times, most recently
from
dcc1463
to
3a4e1f4
Compare
axinging
changed the title
|
@qjia7 @xhcao @haoyunfeix @gyagp PTAL |
qjia7
reviewed
Nov 24, 2022
There was a problem hiding this comment.
Based on #6965's description, it seems that ResizeNearestNeighbor doesn't create the right TypedArray buffer based on dType. Should we fix it there or do the post processing to cast the data to the right type when reading data back like other backends? @pyu10055 @mattsoulanille
|
@pyu10055 @mattsoulanille, PTAL This PR can fix DeepLabV3(in e2e) failure. |
|
Thanks @mattsoulanille. |
axinging
force-pushed
the
checkTypedArrayName
branch
from
27efe53
to
a74bd16
Compare
pyu10055
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained
Linchenn
pushed a commit
to Linchenn/tfjs
that referenced
this pull request
Jan 9, 2023
* Refactor type conversion for read back Bug: tensorflow#6965 * Cleanup Co-authored-by: Ping Yu <4018+pyu10055@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #6965
This change is