Change dependency from saved_model_cli to saved_model_utils #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Hi @BlaziusMaximus Is the saved_model_cli file deprecating and recommend way is to use saved_model_utils?
Reviewable status: 0 of 1 approvals obtained (waiting on @BlaziusMaximus)
tfjs-converter/python/tensorflowjs/converters/tf_saved_model_conversion_v2.py line 46 at r1 (raw file):
from tensorflow.python.saved_model.load import load from tensorflow.python.saved_model import loader from tensorflow.python.tools import saved_model_utils
from tensorflow.python.tools.saved_model_utils import get_meta_graph_def ?
Code quote:
from tensorflow.python.tools import saved_model_utils
|
Yes, exactly. See cl/487288548 for more details. |
pyu10055
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @BlaziusMaximus)
pyu10055
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
thanks
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @BlaziusMaximus)
mattsoulanille
approved these changes
Nov 28, 2022
Linchenn
pushed a commit
to Linchenn/tfjs
that referenced
this pull request
Jan 9, 2023
…ow#7039) * Change dependency from saved_model_cli to saved_model_utils * saved_model_utils import change Co-authored-by: Ping Yu <4018+pyu10055@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is