Fix SparseFillEmptyRows output shape bug #5020
Merged
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
May 3, 2021
There was a problem hiding this comment.
thanks for fixing it, it would be good add description to PR that details the bug, which will help reviewer to understand the issue.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128)
lina128
approved these changes
May 3, 2021
There was a problem hiding this comment.
LGTM
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outputIndices tensor returned by SparseFillEmptyRows has the correct data but the shape was incorrect so it is not enough to check that the data is correct in the tests. The PR fixes this issue and adds a test to ensure that it the shape is now correct.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is