Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal-sentence-encoder packages update #1320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikyo
Copy link

@erikyo erikyo commented Dec 22, 2023

To use this model with the current version of tfjs it is needed to update this package to a version 4 or higher. for the same reason i updated other dependencies from the tests everything works correctly

Summarizing:

  • Package version updated to 1.3.4
  • TensorFlow Updated to >4
  • Typescript to >5
  • some additional dependencies like jasmine, rimraf, ts-node have been updated in order to ensure better functionality and safety

Copy link

google-cla bot commented Dec 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ram-you
Copy link

ram-you commented Jan 5, 2024

We really need this update. Is there a collaborator to check this?
@pyu10055 , your help would be valuable and would be appreciated. Thank you.

@erikyo
Copy link
Author

erikyo commented Jan 7, 2024

@ram-you completely understand and since I was in the same situation and needed it for an experiment (example) I redid the USE package as I needed it. I keep it as long as it is needed and then deprecate it in favor of this one when it is updated (it doesn't matter with this pr or not, I just made it to push it a bit since it really needs an update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants