Sharding custom calls cannot be hoisted individually in WhileLoopInvariantCodeMotion
.
#66574
+50
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharding custom calls cannot be hoisted individually in
WhileLoopInvariantCodeMotion
.A sharding custom call annotates sharding to its operand. If we move a single sharding custom call out of the while body, the sharding annotation may not take effect as expected.
Taking the follow while body as an example,
Before this cl,
WhileLoopInvariantCodeMotion
movessharding.0
out of the body and keepssharding.1
in the body. With this cl,WhileLoopInvariantCodeMotion
does not modify this body.