Make usages of Eigen::array compatible with std::array. #64646
+166
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_619787691
branch
from
b594d6b
to
d02479b
Compare
Eigen::array is no longer necessary, so will be deprecated/removed and replaced with `std::array`. The main difference is the constructor - currently Eigen::array allows `array(a, b, c, ...)` construction, whereas `std::array` requires an initializer list. We also need to remove any direct access to the `Eigen::array::values` internal parameter, in favor of regular index access. PiperOrigin-RevId: 619787691
copybara-service
bot
force-pushed
the
exported_pr_619787691
branch
from
d02479b
to
78385a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make usages of Eigen::array compatible with std::array.
Eigen::array is no longer necessary, so will be deprecated/removed and replaced
with
std::array. The main difference is the constructor - currently Eigen::arrayallows
array(a, b, c, ...)construction, whereasstd::arrayrequires an initializerlist. We also need to remove any direct access to the
Eigen::array::valuesinternal parameter, in favor of regular index access.