Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCS filesystem #48222

Merged
merged 2 commits into from Apr 1, 2021
Merged

Fix GCS filesystem #48222

merged 2 commits into from Apr 1, 2021

Commits on Mar 31, 2021

  1. Switch TF filesystems to keep backwards compatibility.

    Recent changes to enable modular TF can result in breakages or require majority of users to take quick steps to fix their broken code. Instead, we should enable the modular filsystems only if requested by an environment variable and use the legacy behavior in all cases.
    
    In a future TF release, the cloud filesystems will come from different pip packages but we have to design the path towards that to ensure that no one in the TF ecosystem is broken by this. As we stand now, without this change most TF users will need to take action in a P0 basis and this is not desirable.
    
    CC @yongtang, @kvignesh1420, @vnvo2409. Note that I also changed the name of the envvar to match the logic and you'll have to do the same for SIG IO code. Let's sync on SIG IO meeting to discuss further
    
    PiperOrigin-RevId: 365940168
    Change-Id: Id03b793613e521999af47fd6017b70ff659bd23b
    mihaimaruseac committed Mar 31, 2021
    Copy the full SHA
    158505e View commit details
    Browse the repository at this point in the history
  2. Fix typo/logic bug in modular plugins.

    We want to enable plugins only if the environment variable exists!
    
    CC @yongtang, @kvignesh1420, @vnvo2409.
    
    PiperOrigin-RevId: 366056903
    Change-Id: Ia6f0918c97cbd6e064e19a02ce3a7d46f48b2799
    mihaimaruseac committed Mar 31, 2021
    Copy the full SHA
    b9e31e6 View commit details
    Browse the repository at this point in the history