New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Fixing RNNFowardV2 autotuning loop and unit tests #35230
[ROCm] Fixing RNNFowardV2 autotuning loop and unit tests #35230
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
b86b370
to
fd8cae5
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I accidentally deleted the branch, causing the pull request to close. Reopening the pull request again. |
@jerryyin , please resolve the |
Note that the currently running presubmits might still fail. #34532 (comment) |
Thanks for helping out @mihaimaruseac |
The first commit is cherry-picked from #34532, and has been approved in #31849 (authored by @whchung ). Without the first commit, r1.15 branch will not build for the latest ROCm release.
The second commit is cherry picked from #710. Fixed the RNN V2 kernels by enabled the auto-tuning loop in
ROCm
path. It should also fix the warning "No RNN Algorithm Found."cudnn_recurrent_test
used to have 68 failures on value difference, now is all passing