Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Fixing RNNFowardV2 autotuning loop and unit tests #35230

Merged

Conversation

jerryyin
Copy link
Member

@jerryyin jerryyin commented Dec 18, 2019

The first commit is cherry-picked from #34532, and has been approved in #31849 (authored by @whchung ). Without the first commit, r1.15 branch will not build for the latest ROCm release.

The second commit is cherry picked from #710. Fixed the RNN V2 kernels by enabled the auto-tuning loop in ROCm path. It should also fix the warning "No RNN Algorithm Found." cudnn_recurrent_test used to have 68 failures on value difference, now is all passing

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Dec 18, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@jerryyin jerryyin force-pushed the google-upstream-r1.15-zyin-rnn-autotune branch from b86b370 to fd8cae5 Compare December 18, 2019 20:15
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@whchung whchung added the kokoro:force-run Tests on submitted change label Dec 18, 2019
@whchung whchung requested a review from chsigg December 18, 2019 20:16
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 18, 2019
@jerryyin jerryyin closed this Dec 20, 2019
@jerryyin jerryyin deleted the google-upstream-r1.15-zyin-rnn-autotune branch December 20, 2019 17:20
@jerryyin jerryyin restored the google-upstream-r1.15-zyin-rnn-autotune branch January 2, 2020 15:47
@jerryyin
Copy link
Member Author

jerryyin commented Jan 2, 2020

I accidentally deleted the branch, causing the pull request to close. Reopening the pull request again.

@jerryyin jerryyin reopened this Jan 2, 2020
@whchung whchung added the kokoro:force-run Tests on submitted change label Jan 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 2, 2020
@deven-amd
Copy link
Contributor

@jerryyin , please resolve the Ubuntu Sanity failures, and check whether the other failures are related to this PR

@whchung whchung added the kokoro:force-run Tests on submitted change label Jan 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 15, 2020
@mihaimaruseac
Copy link
Collaborator

Note that the currently running presubmits might still fail. #34532 (comment)

@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label Jan 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 16, 2020
@mihaimaruseac mihaimaruseac self-assigned this Jan 16, 2020
@mihaimaruseac mihaimaruseac merged commit 55d3a02 into tensorflow:r1.15 Jan 16, 2020
@jerryyin
Copy link
Member Author

Thanks for helping out @mihaimaruseac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:L CL Change Size: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants